Adding Eventarc Channel Resource support for TPG #6529

daveavi · 2022-09-09T14:17:52Z

I have made changes to the magic-modules repo to support a new resource the Eventarc team has created, called channel.

I have hand written the acceptance test. given that it requires an IAM binding and it uses cloud kms key's, I have bootstrapped the dependencies in order for the test to pass.

Fixes hashicorp/terraform-provider-google#12517

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

google_eventarc_channel

google_eventarc_trigger: Added field `channel` to `google_eventarc_trigger`

modular-magician · 2022-09-09T14:29:22Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 731 insertions(+))
Terraform Beta: Diff ( 5 files changed, 731 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-09-09T14:30:16Z

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Failed tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR
View the build log

modular-magician · 2022-09-09T15:17:38Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 734 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 7 files changed, 734 insertions(+), 1 deletion(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

… right eventarc service

modular-magician · 2022-09-09T16:23:21Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 735 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 7 files changed, 735 insertions(+), 1 deletion(-))
TF Validator: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

modular-magician · 2022-09-09T17:29:19Z

Tests analytics

Total tests: 2171
Passed tests 1878
Skipped tests: 236
Failed tests: 57

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccEventarcChannel_BasicHandWritten|TestAccComputeVpnTunnel_defaultTrafficSelectors|TestAccComputeVpnTunnel_router|TestAccComputeVpnTunnel_regionFromGateway|TestAccComputeRoute_routeIlbVipExample|TestAccComputeVpnTunnel_vpnTunnelBetaExample|TestAccComputeRoute_routeIlbExample|TestAccComputeVpnTunnel_vpnTunnelBasicExample|TestAccComputeVpnGateway_targetVpnGatewayBasicExample|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeRouterInterface_withTunnel|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccComputeRouterInterface_basic|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccComputeGlobalForwardingRule_labels|TestAccComputeGlobalForwardingRule_ipv6|TestAccComputeRouterPeer_bfd|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeForwardingRule_serviceDirectoryRegistrations|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccComputeForwardingRule_networkTier|TestAccComputeRouterPeer_enable|TestAccComputeGlobalForwardingRule_updateTarget|TestAccComputeRouterPeer_advertiseMode|TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleHybridExample|TestAccComputeRouterPeer_basic|TestAccComputeForwardingRule_ip|TestAccComputeBackendBucket_externalCdnLbWithBackendBucketExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleExternalManagedExample|TestAccComputeForwardingRule_update|TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleHttpExample|TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample|TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeForwardingRule_forwardingRuleL3DefaultExample|TestAccComputeForwardingRule_forwardingRuleBasicExample|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeForwardingRule_forwardingRuleExternallbExample|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccCloudRunService_cloudRunServiceMultipleRegionsExample|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccDataSourceGoogleGlobalForwardingRule|TestAccDataSourceGoogleForwardingRule|TestAccComputeFirewallPolicyRule_update|TestAccComputeFirewallPolicyAssociation_basic|TestAccComputeFirewallPolicyRule_multipleRules|TestAccComputeFirewallPolicy_update

modular-magician · 2022-09-09T18:17:52Z

Tests passed during RECORDING mode:
TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate[Debug log]
TestAccComputeGlobalForwardingRule_labels[Debug log]
TestAccComputeGlobalForwardingRule_ipv6[Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Debug log]
TestAccComputeForwardingRule_serviceDirectoryRegistrations[Debug log]
TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample[Debug log]
TestAccComputeGlobalForwardingRule_globalForwardingRuleHybridExample[Debug log]
TestAccComputeForwardingRule_ip[Debug log]
TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample[Debug log]
TestAccComputeGlobalForwardingRule_globalForwardingRuleHttpExample[Debug log]
TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample[Debug log]
TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleHttpLbExample[Debug log]
TestAccComputeFirewallPolicyRule_update[Debug log]

Tests failed during RECORDING mode:
TestAccEventarcChannel_BasicHandWritten[Error message] [Debug log]
TestAccComputeVpnTunnel_router[Error message] [Debug log]
TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample[Error message] [Debug log]
TestAccComputeRouterPeer_bfd[Error message] [Debug log]
TestAccComputeRouterPeer_advertiseMode[Error message] [Debug log]
TestAccComputeRouterPeer_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2022-09-09T18:50:59Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 741 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 7 files changed, 741 insertions(+), 1 deletion(-))
TF Validator: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

modular-magician · 2022-09-09T19:58:04Z

Tests analytics

Total tests: 2171
Passed tests 1892
Skipped tests: 236
Failed tests: 43

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccDataSourceGoogleGlobalForwardingRule|TestAccFirebaserulesRelease_BasicRelease|TestAccEventarcChannel_BasicHandWritten|TestAccDataSourceGoogleForwardingRule|TestAccComputeVpnTunnel_defaultTrafficSelectors|TestAccComputeVpnTunnel_router|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample|TestAccComputeVpnTunnel_regionFromGateway|TestAccComputeVpnTunnel_vpnTunnelBetaExample|TestAccComputeVpnTunnel_vpnTunnelBasicExample|TestAccComputeRouterInterface_withTunnel|TestAccComputeVpnGateway_targetVpnGatewayBasicExample|TestAccComputeRouterInterface_basic|TestAccComputeRouterPeer_bfd|TestAccComputeRouterPeer_enable|TestAccComputeRouterPeer_advertiseMode|TestAccComputeRouterPeer_basic|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeRoute_routeIlbVipExample|TestAccComputeRoute_routeIlbExample|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccComputeGlobalForwardingRule_updateTarget|TestAccComputeForwardingRule_networkTier|TestAccComputeGlobalForwardingRule_globalForwardingRuleExternalManagedExample|TestAccComputeForwardingRule_update|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeForwardingRule_forwardingRuleL3DefaultExample|TestAccComputeForwardingRule_forwardingRuleBasicExample|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeForwardingRule_forwardingRuleExternallbExample|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccComputeBackendBucket_externalCdnLbWithBackendBucketExample|TestAccCloudRunService_cloudRunServiceMultipleRegionsExample|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccComputeFirewallPolicyRule_multipleRules|TestAccComputeFirewallPolicyAssociation_basic|TestAccComputeFirewallPolicy_update

modular-magician · 2022-09-09T22:54:34Z

Tests passed during RECORDING mode:
TestAccComputeVpnTunnel_regionFromGateway[Debug log]
TestAccComputeVpnTunnel_vpnTunnelBasicExample[Debug log]
TestAccComputeRouterInterface_basic[Debug log]
TestAccComputeRoute_routeIlbVipExample[Debug log]
TestAccComputeGlobalForwardingRule_internalLoadBalancing[Debug log]
TestAccComputeGlobalForwardingRule_updateTarget[Debug log]
TestAccComputeGlobalForwardingRule_globalForwardingRuleExternalManagedExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleInternallbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleExternallbExample[Debug log]
TestAccComputeBackendBucket_externalCdnLbWithBackendBucketExample[Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Debug log]
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Debug log]
TestAccComputeFirewallPolicyAssociation_basic[Debug log]
TestAccComputeFirewallPolicy_update[Debug log]

Tests failed during RECORDING mode:
TestAccEventarcChannel_BasicHandWritten[Error message] [Debug log]
TestAccComputeVpnTunnel_router[Error message] [Debug log]
TestAccComputeRouterInterface_withTunnel[Error message] [Debug log]
TestAccComputeRouterPeer_bfd[Error message] [Debug log]
TestAccComputeRouterPeer_enable[Error message] [Debug log]
TestAccComputeRouterPeer_advertiseMode[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2022-09-09T23:18:04Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 741 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 7 files changed, 741 insertions(+), 1 deletion(-))
TF Validator: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

modular-magician · 2022-09-10T00:07:51Z

Tests analytics

Total tests: 2171
Passed tests 1907
Skipped tests: 236
Failed tests: 28

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccEventarcChannel_BasicHandWritten|TestAccFirebaserulesRelease_BasicRelease|TestAccComputeVpnTunnel_defaultTrafficSelectors|TestAccComputeVpnTunnel_router|TestAccComputeVpnTunnel_vpnTunnelBetaExample|TestAccComputeVpnGateway_targetVpnGatewayBasicExample|TestAccComputeRouterInterface_withTunnel|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample|TestAccComputeRouterPeer_bfd|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccComputeForwardingRule_forwardingRuleBasicExample|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccComputeForwardingRule_networkTier|TestAccComputeForwardingRule_update|TestAccComputeForwardingRule_forwardingRuleL3DefaultExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeRouterPeer_enable|TestAccComputeRouterPeer_advertiseMode|TestAccComputeRouterPeer_basic|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeRoute_routeIlbExample|TestAccCloudRunService_cloudRunServiceMultipleRegionsExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccDataSourceGoogleGlobalForwardingRule|TestAccDataSourceGoogleForwardingRule

modular-magician · 2022-09-10T00:13:50Z

Tests passed during RECORDING mode:
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeVpnTunnel_defaultTrafficSelectors[Debug log]
TestAccComputeVpnTunnel_vpnTunnelBetaExample[Debug log]
TestAccComputeVpnGateway_targetVpnGatewayBasicExample[Debug log]
TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleBasicExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample[Debug log]
TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample[Debug log]
TestAccComputeForwardingRule_networkTier[Debug log]
TestAccComputeForwardingRule_forwardingRuleL3DefaultExample[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExample[Debug log]
TestAccComputeRoute_routeIlbExample[Debug log]
TestAccCloudRunService_cloudRunServiceMultipleRegionsExample[Debug log]
TestAccDataSourceGoogleGlobalForwardingRule[Debug log]
TestAccDataSourceGoogleForwardingRule[Debug log]

Tests failed during RECORDING mode:
TestAccEventarcChannel_BasicHandWritten[Error message] [Debug log]
TestAccComputeVpnTunnel_router[Error message] [Debug log]
TestAccComputeRouterPeer_bfd[Error message] [Debug log]
TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample[Error message] [Debug log]
TestAccComputeRouterPeer_advertiseMode[Error message] [Debug log]
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2022-09-12T17:05:55Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 736 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 7 files changed, 736 insertions(+), 1 deletion(-))
TF Validator: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

modular-magician · 2022-09-12T17:59:08Z

Tests analytics

Total tests: 2172
Passed tests 1921
Skipped tests: 237
Failed tests: 14

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccFirebaserulesRelease_BasicRelease|TestAccComputeVpnTunnel_router|TestAccComputeRouterPeer_bfd|TestAccComputeRouterPeer_enable|TestAccComputeRouterPeer_advertiseMode|TestAccEventarcChannel_BasicHandWritten|TestAccComputeRouterPeer_basic|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccComputeRouterInterface_withTunnel|TestAccComputeForwardingRule_update|TestAccCGCSnippet_eventarcWorkflowsExample

modular-magician · 2022-09-12T18:02:54Z

Tests passed during RECORDING mode:
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccEventarcChannel_BasicHandWritten[Debug log]
TestAccComputePacketMirroring_computePacketMirroringFullExample[Debug log]
TestAccComputeForwardingRule_update[Debug log]

Tests failed during RECORDING mode:
TestAccComputeVpnTunnel_router[Error message] [Debug log]
TestAccComputeRouterPeer_bfd[Error message] [Debug log]
TestAccComputeRouterPeer_enable[Error message] [Debug log]
TestAccComputeRouterPeer_advertiseMode[Error message] [Debug log]
TestAccComputeRouterPeer_basic[Error message] [Debug log]
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample[Error message] [Debug log]
TestAccComputeRouterInterface_withTunnel[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

tpgtools/overrides/eventarc/samples/channel/meta.yaml

rileykarson · 2022-09-13T19:50:26Z

mmv1/third_party/terraform/go.mod.erb

@@ -5,7 +5,7 @@ go 1.18

 require (
 	cloud.google.com/go/bigtable v1.16.0
-	github.com/GoogleCloudPlatform/declarative-resource-client-library v1.19.0
+	github.com/GoogleCloudPlatform/declarative-resource-client-library v1.20.1


Note to myself: 1.19.0 -> 1.20.1 has no change impacting Terraform other than this one (but other revisions may add more)

mmv1/third_party/terraform/tests/resource_eventarc_channel_test.go.erb

…t.go.erb Co-authored-by: Riley Karson <rileykarson@google.com>

modular-magician · 2022-09-16T21:10:02Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 15 files changed, 1175 insertions(+), 11 deletions(-))
Terraform Beta: Diff ( 15 files changed, 1175 insertions(+), 11 deletions(-))
TF Validator: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

modular-magician · 2022-09-16T22:08:38Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 15 files changed, 1171 insertions(+), 11 deletions(-))
Terraform Beta: Diff ( 15 files changed, 1171 insertions(+), 11 deletions(-))
TF Validator: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

modular-magician · 2022-09-16T23:11:25Z

Tests analytics

Total tests: 2177
Passed tests 1930
Skipped tests: 238
Failed tests: 9

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeRouterPeer_bfd|TestAccComputeVpnTunnel_router|TestAccComputeRouterPeer_enable|TestAccComputeRouterPeer_advertiseMode|TestAccComputeRouterPeer_basic|TestAccComputeRouterInterface_withTunnel|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccClouddeployTarget_Target

modular-magician · 2022-09-16T23:16:47Z

Tests failed during RECORDING mode:
TestAccComputeRouterPeer_bfd[Error message] [Debug log]
TestAccComputeVpnTunnel_router[Error message] [Debug log]
TestAccComputeRouterPeer_enable[Error message] [Debug log]
TestAccComputeRouterPeer_advertiseMode[Error message] [Debug log]
TestAccComputeRouterPeer_basic[Error message] [Debug log]
TestAccComputeRouterInterface_withTunnel[Error message] [Debug log]
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample[Error message] [Debug log]
TestAccClouddeployTarget_Target[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2022-09-27T17:30:59Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 16 files changed, 1177 insertions(+), 12 deletions(-))
Terraform Beta: Diff ( 16 files changed, 1177 insertions(+), 12 deletions(-))
TF Validator: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

modular-magician · 2022-09-27T18:43:42Z

Tests analytics

Total tests: 2184
Passed tests 1927
Skipped tests: 238
Failed tests: 19

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeRegionBackendServiceIamPolicyGenerated_withCondition|TestAccComputeMachineImageIamPolicyGenerated_withCondition|TestAccComputeInstanceIamPolicyGenerated_withCondition|TestAccComputeBackendServiceIamPolicyGenerated_withCondition|TestAccOrgPolicyPolicy_ProjectPolicy|TestAccOrgPolicyPolicy_FolderPolicy|TestAccComputeRouterInterface_withTunnel|TestAccComputeVpnTunnel_router|TestAccComputeRouterPeer_bfd|TestAccComputeRouterPeer_enable|TestAccComputeRouterPeer_advertiseMode|TestAccComputeRouterPeer_basic|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccComputeForwardingRule_update|TestAccClouddeployTarget_Target|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccPrivatecaCaPoolIamPolicyGenerated_withCondition|TestAccStorageTransferJob_transferOptions

modular-magician · 2022-09-27T18:47:57Z

Tests passed during RECORDING mode:
TestAccComputeRegionBackendServiceIamPolicyGenerated_withCondition[Debug log]
TestAccComputeMachineImageIamPolicyGenerated_withCondition[Debug log]
TestAccComputeInstanceIamPolicyGenerated_withCondition[Debug log]
TestAccComputeBackendServiceIamPolicyGenerated_withCondition[Debug log]
TestAccComputeForwardingRule_update[Debug log]
TestAccPrivatecaCaPoolIamPolicyGenerated_withCondition[Debug log]
TestAccStorageTransferJob_transferOptions[Debug log]

Tests failed during RECORDING mode:
TestAccOrgPolicyPolicy_ProjectPolicy[Error message] [Debug log]
TestAccOrgPolicyPolicy_FolderPolicy[Error message] [Debug log]
TestAccComputeRouterInterface_withTunnel[Error message] [Debug log]
TestAccComputeVpnTunnel_router[Error message] [Debug log]
TestAccComputeRouterPeer_bfd[Error message] [Debug log]
TestAccComputeRouterPeer_enable[Error message] [Debug log]
TestAccComputeRouterPeer_advertiseMode[Error message] [Debug log]
TestAccComputeRouterPeer_basic[Error message] [Debug log]
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample[Error message] [Debug log]
TestAccClouddeployTarget_Target[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

rileykarson · 2022-10-05T18:26:02Z

Continuing to wait on the DCL version to get upgraded- there was an attempt to use 1.21.1 but it got reverted (#6592). Both #6614 and #6639 are in progress to update it.

…i/magic-modules into add-eventarc-channel-test

modular-magician · 2022-11-07T22:17:13Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 955 insertions(+))
Terraform Beta: Diff ( 6 files changed, 939 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-11-07T23:02:54Z

Tests analytics

Total tests: 2225
Passed tests 1983
Skipped tests: 240
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccEventarcTrigger_channel|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample

modular-magician · 2022-11-07T23:08:04Z

Tests passed during RECORDING mode:
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Debug log]

Tests failed during RECORDING mode:
TestAccEventarcTrigger_channel[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

mmv1/third_party/terraform/tests/resource_eventarc_trigger_test.go.erb

modular-magician · 2022-11-08T00:27:50Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 9 files changed, 959 insertions(+))
Terraform Beta: Diff ( 9 files changed, 959 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-11-08T01:19:01Z

Tests analytics

Total tests: 2225
Passed tests 1985
Skipped tests: 240
Failed tests: 0

All tests passed in REPLAYING mode
View the build log

rileykarson

LGTM, thanks! Sorry about the extended delay w/ the DCL upgrade, we'll try to make sure that doesn't happen again 🙁

When referencing an issue from a PR that fixes it, you can use the magic word "Fixes" or "Resolves" followed by the issue link to close it automatically! I've edited the parent comment to do so.

…#6529) Co-authored-by: Riley Karson <rileykarson@google.com> Fixes hashicorp/terraform-provider-google#12517

daveavi added 3 commits September 7, 2022 23:03

feat: added hand writtent test for eventarc channel acceptance test

5dfbdfe

fix: able to now generate doc's without generating sample

23be6f1

nit: removed minimal test

be4a174

daveavi requested a review from rileykarson as a code owner September 9, 2022 14:17

fix: updating DCL v.1.20.1

8a3daa0

daveavi added 3 commits September 9, 2022 15:49

fix: changed test file to ruby template file to check version, to get…

9009d25

… right eventarc service

fix: deleted test go file

0f258e3

fix: added the deletion to commit

5bd6f75

fix: enabling eventarcpublishing before trying to create channel

3ee0035

fix: put data infront of google_project

08a8a56

fix: removing eventarcpublishing dependency in test

abe222f

rileykarson reviewed Sep 13, 2022

View reviewed changes

rileykarson mentioned this pull request Sep 13, 2022

Adding Eventarc GoogleChannelConfig Resource support for TPG #6534

Merged

5 tasks

Update mmv1/third_party/terraform/tests/resource_eventarc_channel_tes…

048bf16

…t.go.erb Co-authored-by: Riley Karson <rileykarson@google.com>

modular-magician requested a review from rileykarson September 13, 2022 21:12

fix: ommiting project field

532d89f

nit: updating dcl version to v1.22.1

5d20438

daveavi mentioned this pull request Oct 20, 2022

Upgrade the dcl version to v1.26.0 #6639

Merged

4 tasks

daveavi added 4 commits November 7, 2022 16:55

Merge branch 'main' into add-eventarc-channel-test

48c4d39

fix: update dcl version to v1.26.2

27e0d83

Merge branch 'main' into add-eventarc-channel-test

f0f3a37

Merge branch 'add-eventarc-channel-test' of https://github.com/daveav…

64601b2

…i/magic-modules into add-eventarc-channel-test

rileykarson reviewed Nov 8, 2022

View reviewed changes

mmv1/third_party/terraform/tests/resource_eventarc_trigger_test.go.erb Show resolved Hide resolved

fix: remove channel field

adf5112

modular-magician requested a review from rileykarson November 8, 2022 00:14

rileykarson approved these changes Nov 11, 2022

View reviewed changes

rileykarson merged commit 97e58be into GoogleCloudPlatform:main Nov 11, 2022

This was referenced Nov 11, 2022

Adding Eventarc Channel Resource support for TPG hashicorp/terraform-provider-google-beta#4876

Merged

Adding Eventarc Channel Resource support for TPG hashicorp/terraform-provider-google#13021

Merged

googlerjk pushed a commit to googlerjk/magic-modules that referenced this pull request Nov 22, 2022

Adding Eventarc Channel Resource support for TPG (GoogleCloudPlatform…

60f2ec1

…#6529) Co-authored-by: Riley Karson <rileykarson@google.com> Fixes hashicorp/terraform-provider-google#12517

googlerjk pushed a commit to googlerjk/magic-modules that referenced this pull request Nov 25, 2022

Adding Eventarc Channel Resource support for TPG (GoogleCloudPlatform…

bfa1f5d

…#6529) Co-authored-by: Riley Karson <rileykarson@google.com> Fixes hashicorp/terraform-provider-google#12517

hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Dec 6, 2022

Adding Eventarc Channel Resource support for TPG (GoogleCloudPlatform…

f288d68

…#6529) Co-authored-by: Riley Karson <rileykarson@google.com> Fixes hashicorp/terraform-provider-google#12517

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding Eventarc Channel Resource support for TPG #6529

Adding Eventarc Channel Resource support for TPG #6529

daveavi commented Sep 9, 2022 •

edited by rileykarson

Loading

modular-magician commented Sep 9, 2022

modular-magician commented Sep 9, 2022

modular-magician commented Sep 9, 2022

modular-magician commented Sep 9, 2022

modular-magician commented Sep 9, 2022

modular-magician commented Sep 9, 2022

modular-magician commented Sep 9, 2022

modular-magician commented Sep 9, 2022

modular-magician commented Sep 9, 2022

modular-magician commented Sep 9, 2022

modular-magician commented Sep 10, 2022

modular-magician commented Sep 10, 2022

modular-magician commented Sep 12, 2022

modular-magician commented Sep 12, 2022

modular-magician commented Sep 12, 2022

rileykarson Sep 13, 2022

modular-magician commented Sep 16, 2022

modular-magician commented Sep 16, 2022

modular-magician commented Sep 16, 2022

modular-magician commented Sep 16, 2022

modular-magician commented Sep 27, 2022

modular-magician commented Sep 27, 2022

modular-magician commented Sep 27, 2022

rileykarson commented Oct 5, 2022

modular-magician commented Nov 7, 2022

modular-magician commented Nov 7, 2022

modular-magician commented Nov 7, 2022

modular-magician commented Nov 8, 2022

modular-magician commented Nov 8, 2022

rileykarson left a comment

Adding Eventarc Channel Resource support for TPG #6529

Adding Eventarc Channel Resource support for TPG #6529

Conversation

daveavi commented Sep 9, 2022 • edited by rileykarson Loading

modular-magician commented Sep 9, 2022

Diff report:

modular-magician commented Sep 9, 2022

Tests analytics

modular-magician commented Sep 9, 2022

Diff report:

modular-magician commented Sep 9, 2022

Diff report:

modular-magician commented Sep 9, 2022

Tests analytics

Action taken

modular-magician commented Sep 9, 2022

modular-magician commented Sep 9, 2022

Diff report:

modular-magician commented Sep 9, 2022

Tests analytics

Action taken

modular-magician commented Sep 9, 2022

modular-magician commented Sep 9, 2022

Diff report:

modular-magician commented Sep 10, 2022

Tests analytics

Action taken

modular-magician commented Sep 10, 2022

modular-magician commented Sep 12, 2022

Diff report:

modular-magician commented Sep 12, 2022

Tests analytics

Action taken

modular-magician commented Sep 12, 2022

rileykarson Sep 13, 2022

Choose a reason for hiding this comment

modular-magician commented Sep 16, 2022

Diff report:

modular-magician commented Sep 16, 2022

Diff report:

modular-magician commented Sep 16, 2022

Tests analytics

Action taken

modular-magician commented Sep 16, 2022

modular-magician commented Sep 27, 2022

Diff report:

modular-magician commented Sep 27, 2022

Tests analytics

Action taken

modular-magician commented Sep 27, 2022

rileykarson commented Oct 5, 2022

modular-magician commented Nov 7, 2022

Diff report

modular-magician commented Nov 7, 2022

Tests analytics

Action taken

modular-magician commented Nov 7, 2022

modular-magician commented Nov 8, 2022

Diff report

modular-magician commented Nov 8, 2022

Tests analytics

rileykarson left a comment

Choose a reason for hiding this comment

daveavi commented Sep 9, 2022 •

edited by rileykarson

Loading